[Bioperl-l] Re: [Bioperl-guts-l] bioperl-live/Bio/SeqFeature Annotated.pm, 1.17, 1.18

[Allen Day]

i don't think it should do this, the whole point of using an AC is to
retain typing.  if you want to have a friendly stringification of the
source attribute, use overloading in SimpleValue.  there is an as_text()
method already in there that is currently commented out.

-allen


On Thu, 25 Nov 2004, Steffen Grossman wrote:

> Update of /home/repository/bioperl/bioperl-live/Bio/SeqFeature
> In directory pub.open-bio.org:/tmp/cvs-serv22868
> 
> Modified Files:
> 	Annotated.pm 
> Log Message:
> 'source' now gives back its value instead of a
> Bio::Annotation::SimpleValue object. (This is consisitent with
> 'type').
> 
> 
> Index: Annotated.pm
> ===================================================================
> RCS file: /home/repository/bioperl/bioperl-live/Bio/SeqFeature/Annotated.pm,v
> retrieving revision 1.17
> retrieving revision 1.18
> diff -C2 -d -r1.17 -r1.18
> *** Annotated.pm	24 Nov 2004 16:31:59 -0000	1.17
> --- Annotated.pm	25 Nov 2004 10:02:50 -0000	1.18
> ***************
> *** 181,185 ****
>     }
>   
> !   return $self->get_Annotations('source');
>   }
>   
> --- 181,188 ----
>     }
>   
> !   my $source_anno = $self->get_Annotations('source');
> !   
> !   return $source_anno->value if ($source_anno);
> !   return undef;
>   }
>   
> 
> _______________________________________________
> Bioperl-guts-l mailing list
> Bioperl-guts-l at portal.open-bio.org
> http://portal.open-bio.org/mailman/listinfo/bioperl-guts-l
>