[Bioperl-l] Bio::DB::EMBL
Ewan Birney
birney@ebi.ac.uk
Wed, 4 Apr 2001 18:28:36 +0100 (BST)
On Wed, 4 Apr 2001, Hilmar Lapp wrote:
> Jason Stajich wrote:
> > > >
> > > > I've just committed Bio::DB::EMBL which has four methods for
> > > > retrieving entries:
> > > >
> > > > get_Seq_by_id()
> > > > get_Seq_by_acc()
> > > > get_Seq_by_version()
> > > > get_Stream_by_batch()
> > > >
> > > >
> > > > Design issues:
> > > >
> > > > The get_Seq_by_version() is a new method and should probably be added
> > > > into
> > > >
>
> I agree with Ewan's suggestion here. get_Seq_by_acc_version()
> sounds more intuitive (to me).
>
> As for the interface, I'm not sure. I think if we put it there,
> implementors should at least be able to fake it if the underlying
> DB doesn't provide for versioned seqs. E.g., for those
> get_Seq_by_acc_version() is the same as calling get_Seq_by_acc().
> Would that make sense?
We could let implementations throw an exception. This is not a
particularly nice solution. Hmmmmm. Perhaps it is best to keep it out of
the interface.
I'm undecided now....