[Bioperl-l] Annotated.pm

[Hilmar Lapp]

On Friday, November 26, 2004, at 11:06  PM, Allen Day wrote:

>> As an aside, your get_Annotations() short-cut is brittle. If someone
>> happens to add a second 'source' annotation (or any other tag for that
>> matter), it will break and return the length of the array instead of
>
> this is intentional and documented.

Maybe I'm missing something but I'm not sure why you would want code 
that is brittle on purpose. Why would that help the end user?

>
>> the first element. Furthermore, I wouldn't test for IS-A
>> Bio::Annotation::OntologyTerm - this is only an implementation class
>> and one day there may be better ones. What you really care about is
>> that the object IS-A Bio::AnnotationI (so that you can add it to the
>> collection) and IS-A Bio::Ontology::TermI (so that you have your
>> ontology-enforced typing).
>
> what class are you referring to here?

The one in the subject line.

	-hilmar
-- 
-------------------------------------------------------------
Hilmar Lapp                            email: lapp at gnf.org
GNF, San Diego, Ca. 92121              phone: +1-858-812-1757
-------------------------------------------------------------