[Bioperl-l] bptutorial 24 bug

albert vilella vilella at bio.ub.es
Wed Jul 16 14:27:35 EDT 2003


Hi,

I've found that the bptutorial in bioperl-live-1.2.2 has a couple of, 
possibly, typos that affect the test 24 (clustalw and t_coffee):

There are a couple of:

       unless( $factory->executable ) {

that should be:

       unless( !$factory->executable ) {

In order to find the executable for clustalw and t_coffee.

I created an account in bugzilla but haven't received my password, so I
send a patch.

Thanks,

Albert


-------------- next part --------------
--- bptutorial.pl	2003-06-30 16:12:56.000000000 +0200
+++ bptutorial.pl	2003-07-15 15:34:13.000000000 +0200
@@ -3398,7 +3398,7 @@
 	# where @seq_array is an array of Bio::Seq objects
 	@params = ('ktuple' => 2, 'matrix' => 'BLOSUM', 'quiet' => 1);
 	$factory = Bio::Tools::Run::Alignment::Clustalw->new(@params);
-	unless( $factory->executable ) {
+	unless( !$factory->executable ) {
 	    $ktuple = 3;
 	    $factory->ktuple($ktuple);  # change the parameter before executing
 	    $aln = $factory->align($seq_array_ref);
@@ -3422,7 +3422,7 @@
     }
     @params = ('ktuple' => 2, 'matrix' => 'BLOSUM', 'quiet' => 1);
     $factory = Bio::Tools::Run::Alignment::TCoffee->new(@params);
-    unless( $factory->executable ) {
+    unless( !$factory->executable ) {
 	$ktuple = 3;
         $factory->ktuple($ktuple);  # change the parameter before executing
         $aln = $factory->align($seq_array_ref);


More information about the Bioperl-l mailing list