[Bioperl-l] SeqFeature->_expand_region
Hilmar Lapp
hlapp at gmx.net
Thu Jul 3 02:08:52 EDT 2003
On Wednesday, July 2, 2003, at 10:18 PM, Hilmar Lapp wrote:
>
> On Wednesday, July 2, 2003, at 09:50 PM, Chris Mungall wrote:
>
>> are you suggesting we change Location::Atomic to return undefined
>> when not
>> known?
>>
>
> Not when not known but when not set. I.e., simply
>
> return $self->{'_strand'};
>
> instead of
>
> return $self->{'_strand'} || 0;
>
> I'm testing this right now for its knock-on effects. I suspect there
> might be some. But my take is that it is almost always wrong to make
> up a value where none has been set.
OK - done. Indeed there was a whole cascade of knock-on effects. I
fixed them all. Scary.
Shall I migrate this to the branch? Heikki what's your call?
Chris, does your use case work now?
-hilmar
--
-------------------------------------------------------------
Hilmar Lapp email: lapp at gnf.org
GNF, San Diego, Ca. 92121 phone: +1-858-812-1757
-------------------------------------------------------------
More information about the Bioperl-l
mailing list