[Bioperl-l] Small-bugfix in BPpsilite.pm
Jason Stajich
jason@chg.mc.duke.edu
Thu, 5 Jul 2001 09:10:33 -0400 (EDT)
Thank you Arne - all the changes looks good.
The FILEHANDLE should be closed when it goes out of scope in the
_preprocess method, but we should explictly close it as you have added.
Thanks for sending a note to the list - can you be sure and include
comments in your commits in the future though, so someone can interpret
your changes by looking at the log messages for a file.
When you do cvs commit make sure you specify the -m flag with a comment
like:
% cvs commit -m "your message here" [specific module to commit - or leave
blank to commit all changes in CWD]
Quick question regarding Iteration changes:
Are you sure you want to check only on A-Z - do want the pattern to check
for lowercase as well? This then expects all Query lines from PSIBLAST to
be uppercased - perhaps that is always the case?
-Jason
On 5 Jul 2001, Arne Elofsson wrote:
>
> Hi again
>
> I noticed that in _preprocess the temporary files where not
> closed. This results in that the whole file from tha last iteration
> can not be read. This is fixed.
>
> yours
>
> arne
>
> PS. Also made a small change to the regexp processing in
> Iteration::Align to handle this processing better.
>
>
> --
> ------------------------------------------------------------------------
> OBS: New Phone number from July 27; +46-8-553 78 568
> ------------------------------------------------------------------------
> Arne Elofsson Stockholm Bioinformatics Center
> Net: arne@sbc.su.se http://www.sbc.su.se/~arne/
> Tel:+46-8-161553 Stockholm Bioinformatics Center, Stockholm University
> Fax:+46-8-158057 10691 Stockholm, Sweden
> _______________________________________________
> Bioperl-l mailing list
> Bioperl-l@bioperl.org
> http://bioperl.org/mailman/listinfo/bioperl-l
>
Jason Stajich
jason@chg.mc.duke.edu
Center for Human Genetics
Duke University Medical Center
http://www.chg.duke.edu/