[MOBY-dev] Re: [MISC] CommonSubs.pm

[mwilkinson]

Oh, I dunno Simon... But thanks for your (misplaced) faith :-)

There were a couple of hours a few days ago where I broke things badly!  Hence my impetus to finally set up a development server in Halifax.

However, you are right - I am trying to be much more careful now that we have so many users.  Generally I install the changes on my local server first and run the test suites.  From now on I will install it remotely on the dev server and test it there as well before finally committing it to the production registry!!

It's a dangerous time code-wise, as I am now going through the entire codebase and rearranging it to reflect a better architecture and design philosophy (to actually *have* a design philosophy, for a start ;-) ).  There's a lot of opportunity for error in there, but hopefully the code will become easier to maintain/extend once it's done.

Cheers all!  I'm off to Winnipeg (the belly-button of Canada) to teach bioperl-for-newbies for a few days, so I'll be out of touch until Monday.

Martin, I'll see you in Manila in a couple of weeks - hopefully we can push forward the CGIAR MOBY plans there!  ...exciting times!!!!

M

-----Original Message-----
From: Simon Twigger <simont at mcw.edu>
Date: Wed, 16 Jun 2004 14:57:27 
To:markw at illuminae.com,       Core developer announcements <moby-dev at portal.open-bio.org>
Subject: Re: [MOBY-dev] Re: [MISC] CommonSubs.pm

This makes sense, it did seem odd that you would commit something that  
broke everything!

Cheers,

Simon.

On Jun 16, 2004, at 2:25 PM, Mark Wilkinson wrote:

> Hi Simon,
>
> This is likely specific to you - it looks like you have done some
> tweaking of that part of the code, which caused a CVS versioning
> conflict when you merged the public code into your own (the <<<<< and
>>>>>> sections reveal what the conflict was)  just pick the more recent
> one and delete the rest.
>
> cheers!
>
> M
>
>
> On Wed, 2004-06-16 at 12:20, Simon Twigger wrote:
>> Hi Mark,
>>
>> I updated my copy of the cvs today to get CommonSubs working with
>> myservices - I had been using some of Ken's modules before.
>>
>> To get it to work I had to go in and hack the code
>> aroundCommonSubs::responseHeader() (See below)
>>
>> I had to comment out the <<<<<<<, ========= and >>>>>>>>> linesas they
>> were causing things to break, Im guessing they were diffannotations or
>> similar?
>>
>>
>> Thought Id let you know, I didnt want to mess with the CVS
>> bycommitting anything just in case its meant to be like this and Im
>> justmissing something!
>>
>> Simon.
>>
>> sub responseHeader {
>> # <<<<<<< CommonSubs.pm
>>
>> warn "responseHeader Called..\n";
>>
>>     my ($auth) = @_;
>> # =======
>>     use HTML::Entities ();
>>     my ($auth, $notes) = &_rearrange([qw[AUTHORITY NOTE]], @_);
>> # >>>>>>> 1.50
>>     $auth ||="not_provided";
>>     $notes ||="";
>>     my $xml = "<?xml version='1.0' encoding='UTF-8'?>".
>>         "<moby:MOBY
>> xmlns:moby='http://www.biomoby.org/moby'xmlns='http:// 
>> www.biomoby.org/moby'>".
>>         "<moby:mobyContent moby:authority='$auth'>";
>>     if ($notes){
>>         my $encodednotes = HTML::Entities::encode($notes);
>>         $xml.="<moby:serviceNotes>$encodednotes</moby:serviceNotes>";
>>     }
>>     return $xml;
>> }
>>
>>
>> --
>>
>> Simon N. Twigger, Ph.D.
>> Assistant Professor, Department of Physiology
>> Medical College of Wisconsin
>> 8701 Watertown Plank Road,
>> Milwaukee, WI, USA
>> tel: 414-456-8802
>> fax: 414-456-6595
>> AIM/iChat: simontatmcw
> -- 
> Mark Wilkinson (mwilkinson at mrl.ubc.ca)
> University of British Columbia iCAPTURE Centre
> _______________________________________________
> MOBY-dev mailing list
> MOBY-dev at biomoby.org
> http://www.biomoby.org/mailman/listinfo/moby-dev
>
>
--

Simon N. Twigger, Ph.D.
Assistant Professor, Department of Physiology
Medical College of Wisconsin
8701 Watertown Plank Road,
Milwaukee, WI, USA
tel: 414-456-8802
fax: 414-456-6595
AIM/iChat: simontatmcw

_______________________________________________
MOBY-dev mailing list
MOBY-dev at biomoby.org
http://www.biomoby.org/mailman/listinfo/moby-dev

!!!!!!!!!!!!!!!!
To respond to this message you MUST send your response to (note new address!)

markw_mobile2 at illuminae dot com

Responses to the reply-to address go directly to trash!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!