[Biojava-dev] SimpleThreadPool priority change

[Keith James]

>>>>> "Paul" == Paul Seed <Paul.Seed@geneprot.com> writes:

    Paul> Hello - I'd like to use the SimpleThreadPool in the utils
    Paul> package with a small enhancement to allow the thread
    Paul> priority to be specified in the constructor.  We should just
    Paul> need to add a call like:

    Paul>                 threads[i].setPriority(priority);

    Paul> ...to the startThreads() method before launching the thread.
    Paul> Unfortunately it's not possible to do this in a subclass of
    Paul> SimpleThreadPool as the threads member is private, as is the
    Paul> PooledThread inner class.

[...]

Hi Paul,

I've added a constructor which accepts a priority value. I also made
the priority and thread members protected. I *think* this is okay, but
I can't build  or runtests because the build is currently broken:

compile:
    [javac] Compiling 913 source files to /nfs/team81/kdj/devel/biojava-live/ant-build/classes/main
    [javac] /nfs/team81/kdj/devel/biojava-live/ant-build/src/main/org/biojava/bio/seq/SubSequence.java:352: getParent(org.biojava.bio.seq.Feature) is inherited from org.biojava.bio.seq.ProjectedFeatureHolder and hides method in outer class org.biojava.bio.seq.SubSequence.  An explicit 'this' qualifier must be used to select the desired instance.
    [javac]                  return(ssthis.new SSRemoteFeature(ssthis, this, getParent(f), rft, f));
    [javac]                                                                  ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -deprecation for details.
    [javac] 1 error

BUILD FAILED
file:/nfs/team81/kdj/devel/biojava-live/build.xml:266: Compile failed; see the compiler error output for details.

cheers,

Keith

-- 

- Keith James <kdj@sanger.ac.uk> bioinformatics programming support -
- Pathogen Sequencing Unit, The Wellcome Trust Sanger Institute, UK -