[MOBY-guts] biomoby commit

Mark Wilkinson mwilkinson at pub.open-bio.org
Fri Sep 30 23:14:13 UTC 2005


mwilkinson
Fri Sep 30 19:14:12 EDT 2005
Update of /home/repository/moby/moby-live/Perl/MOBY
In directory pub.open-bio.org:/tmp/cvs-serv8149/MOBY

Modified Files:
	OntologyServer.pm 
Log Message:
OntologyServer was returning NCBI_Acc as the namespace if you passed it a null query. Yuck

moby-live/Perl/MOBY OntologyServer.pm,1.87,1.88
===================================================================
RCS file: /home/repository/moby/moby-live/Perl/MOBY/OntologyServer.pm,v
retrieving revision 1.87
retrieving revision 1.88
diff -u -r1.87 -r1.88
--- /home/repository/moby/moby-live/Perl/MOBY/OntologyServer.pm	2005/09/30 23:08:35	1.87
+++ /home/repository/moby/moby-live/Perl/MOBY/OntologyServer.pm	2005/09/30 23:14:12	1.88
@@ -191,7 +191,7 @@
 	$term =~ s/^moby://;    # if the term is namespaced, then remove that
 	my $sth;
 	return ( 0, "WRONG ONTOLOGY!", '' ) unless ( $self->ontology eq 'object' );
-	return (0, undef, undef) unless defined $term;
+	return (0, undef, undef) unless $term;
 
 	my $result;
 	
@@ -654,7 +654,7 @@
 	{
 		return ( 1, "external ontology", $term );
 	}
-	return (0, undef, undef) unless defined $term;
+	return (0, undef, undef) unless $term;
 
 	my $result;
 	$result = $adaptor->query_service(type => $term);
@@ -786,7 +786,7 @@
 	return ( 0, "WRONG ONTOLOGY!", '' )
 	  unless ( $self->ontology eq 'namespace' );
 	my $term = $args{term};
-	return (0, undef, undef) unless defined $term;
+	return (0, undef, undef) unless $term;
 	$term =~ s/^moby://;    # if the term is namespaced, then remove that
 	if ( $term =~ /^urn:lsid/
 		 && !( $term =~ /^urn:lsid:biomoby.org:namespacetype/ ) )




More information about the MOBY-guts mailing list