[MOBY-guts] biomoby commit

Mark Wilkinson mwilkinson at pub.open-bio.org
Fri Jul 22 23:15:55 UTC 2005


mwilkinson
Fri Jul 22 19:15:54 EDT 2005
Update of /home/repository/moby/moby-live/Perl/MOBY
In directory pub.open-bio.org:/tmp/cvs-serv2410/MOBY

Modified Files:
	Central.pm 
Log Message:
secondaries that had 0 as their min, max, or default vaules were not registering properly because of a test for value rather than defined.  Smae problem on the server side

moby-live/Perl/MOBY Central.pm,1.176,1.177
===================================================================
RCS file: /home/repository/moby/moby-live/Perl/MOBY/Central.pm,v
retrieving revision 1.176
retrieving revision 1.177
diff -u -r1.176 -r1.177
--- /home/repository/moby/moby-live/Perl/MOBY/Central.pm	2005/07/22 23:11:49	1.176
+++ /home/repository/moby/moby-live/Perl/MOBY/Central.pm	2005/07/22 23:15:54	1.177
@@ -22,7 +22,7 @@
 use MOBY::secondary_input;
 use MOBY::central_db_connection;
 use MOBY::Config;
-use MOBY::Client::Central;
+#use MOBY::Client::Central;
 
 #use MOBY::RDF::ServiceInstanceRDF;
 #use RDF::Core;
@@ -3511,19 +3511,14 @@
 		$output .= "\t<secondaryArticles>\n";
 		$result = $adaptor->query_secondary_input({service_instance_id => $_});
 		foreach my $row (@$result)
-		{
-		    my $default_value = $row->{default_value};
-		    my $maximum_value = $row->{maximum_value};
-		    my $minimum_value = $row->{minimum_value};
-		    my $enum_value = $row->{enum_value};
-		    my $datatype = $row->{datatype};
-		    my $article_name = $row->{article_name};
-
-			defined($article_name)  ||= "";
-			defined($datatype)      ||= "";
-			defined($default_value) ||= "";
-			defined($maximum_value) ||= "";
-			defined($minimum_value) ||= "";
+		{  my($default_value, $maximum_value, $minimum_value, $enum_value, $datatype, $article_name) = "";
+		    $default_value = $row->{default_value};
+		    $maximum_value = $row->{maximum_value};
+		    $minimum_value = $row->{minimum_value};
+		    $enum_value = $row->{enum_value};
+		    $datatype = $row->{datatype};
+		    $article_name = $row->{article_name};
+
 			$output .= "\t\t\t<Parameter articleName='$article_name'>\n";
 			$output .= "\t\t\t\t<datatype>$datatype</datatype>\n";
 			$output .= "\t\t\t\t<default>$default_value</default>\n";




More information about the MOBY-guts mailing list