[MOBY-dev] Bug in MobyRequest ?

[Paul Gordon]

> thanks for the update... Although I aggree with you on the primary data issue, 
> I wouldnt call it 'being lazy'... why are then default values at all if one 
> is forced to send the secondaries at all ? If I'm ok with the defined default 
> values, why should I send secondaries ? I understood the secondaries as 
> optional parameters for which I could just use the default values.
>   
Well, MobyRequest never said it would fill secondaries in for you, so I 
don't consider it a "bug" that it didn't :-)
i.e. MobyRequest does not expect to fulfill all the contract obligations 
of a transaction (e.g. the API user is still responsible for data type 
conformity), so I considered it more like a "Request For Enhancement".

> but what surprises me is, when actually does the secondaries are set to the 
> request data ?
> When I see the code correctly, you fill the secondaryParams - but I cant find 
> anything where this information is then set ?
>
> MobyDataUtils.toXMLDocument( mobyRequest, data );
>
> seems to be where you create the xml request with the data... but where is the 
> link between data and the parameters ?
>   
Mea culpa. 
Now that actually is a bug, just introduced :-)
Since it was a fairly trivial modification, I had only tested that my 
changes didn't break anything, not that they actually worked. :-(
Please do another cvs update.  On the plus side, I also made the code 
somewhat prettier by using the Java 5 "for each" and more Generics in 
the main loops.