[Biopython-dev] GitHub's CODEOWNERS to automate pull request review assignment

Peter Cock p.j.a.cock at googlemail.com
Tue Sep 26 10:30:56 UTC 2017


Here's a pull request for comment - this initially only
covers a fraction of the code base:

https://github.com/biopython/biopython/pull/1399

Peter

On Thu, Sep 21, 2017 at 4:28 PM, João Rodrigues
<j.p.g.l.m.rodrigues at gmail.com> wrote:
> Yeah, sure, sounds good.
>
> As for preference, I'd put it under .git, users shouldn't have to worry
> about it.
>
>
> On qui, 21/09/2017, 08:25 Peter Cock <p.j.a.cock at googlemail.com> wrote:
>>
>> Great.
>>
>> What would you like to have automatically assigned to you
>> to review? Changes touching Bio/PDB/* perhaps?
>>
>> Also any preference putting the magic file CODEOWNERS
>> at top level, or under .github/CODEOWNERS instead?
>>
>> Peter
>>
>> P.S. Returning to the other thread, the master branch is
>> now protected and should only be changed via tested
>> pull requests:
>>
>>
>> http://mailman.open-bio.org/pipermail/biopython-dev/2017-September/021872.html
>>
>>
>> On Thu, Sep 21, 2017 at 4:21 PM, João Rodrigues
>> <j.p.g.l.m.rodrigues at gmail.com> wrote:
>> > Hi Peter,
>> >
>> > Sounds like a good policy to me. Also for the branch protection, makes
>> > perfect sense.
>> >
>> > Cheers,
>> >
>> > João
>> >
>> >
>> > On qua, 20/09/2017, 14:13 Peter Cock <p.j.a.cock at googlemail.com> wrote:
>> >>
>> >> Hi all,
>> >>
>> >> I recently learnt of another GitHub feature which may be
>> >> of use for Biopython:
>> >>
>> >> https://github.com/blog/2392-introducing-code-owners
>> >>
>> >> The Galaxy Project are now trying this for their repository of
>> >> training materials (which is how I heard about the idea):
>> >>
>> >> https://github.com/galaxyproject/training-material/pull/539
>> >>
>> >> The idea is we can label a default owner for files or entire
>> >> folders, and if a pull request changes those files, GitHub
>> >> will automatically assign their owner as a reviewer.
>> >>
>> >> For example, we might include the following mappings:
>> >>
>> >> Bio/Cluster/* @mdehoon
>> >> Bio/SeqIO/* @peterjc
>> >> Bio/PopGen/* @tiagoantao
>> >> Bio/Phylo/* @etal
>> >> ...
>> >>
>> >> This can be combined with the branch protection options,
>> >> which I proposed using recently:
>> >>
>> >>
>> >>
>> >> http://mailman.open-bio.org/pipermail/biopython-dev/2017-August/021861.html
>> >>
>> >> Peter
>> >> _______________________________________________
>> >> Biopython-dev mailing list
>> >> Biopython-dev at mailman.open-bio.org
>> >> http://mailman.open-bio.org/mailman/listinfo/biopython-dev



More information about the Biopython-dev mailing list