[Biopython-dev] duplicate function names in Tests/test_Entrez.py

Peter Cock p.j.a.cock at googlemail.com
Thu Dec 3 19:54:26 UTC 2015

Hi Carlos,

Fair point, you did spot this first but unfortunately I missed that
amongst the main goal of your pull request:


I should have also named you in my commits fixing this. Sorry.

Rather than using your pull request as is, I'm planning to pull out the
refactoring work you did from that pull request in order to get the URL
construction tested first. (Assuming Michiel has no objections)

Vincent's pull request about using context manages was much
easier to review - just the nature of the changes:


But anyway, thank you both for spotting the method name clash
in test_Entrez.py - its been fixed now :)



On Thu, Dec 3, 2015 at 7:16 PM, Carlos Peña <carlos.pena at utu.fi> wrote:
> I have a pull request dealing with test_Entrez and also noticed the
> duplicated test. I think that one on them runs and the other fails, so I
> removed one.
> See
> https://github.com/carlosp420/biopython/commit/625392d557ae9cb9838b0d53f238e947e96655fd

More information about the Biopython-dev mailing list