[Biopython-dev] pull request: Handle MMCIF with multiple models (closes 2943)

Peter Cock p.j.a.cock at googlemail.com
Mon Apr 23 17:02:01 UTC 2012


On Sun, Apr 22, 2012 at 7:48 AM, Lenna Peterson <arklenna at gmail.com> wrote:
> I've implemented the parser changes (written by Paul Bathen; see bug
> report) to allow the MMCIF parser to handle multiple models.
>
> Models are now accessed by a string key of their model number, rather
> than an arbitrary index (structure['1'] versus structure[0]).
>
> I updated the MMCIF unit test for the new model access method and
> added a test file with multiple models.
>
> I'm not sure if there is documentation to be updated re: accessing the models.
>
> issue: https://redmine.open-bio.org/issues/2943
> pull request: https://github.com/biopython/biopython/pull/34

I've applied that to the trunk, thank you, but on reading this, why are the
model keys strings and not integers? Does MMCIF allow odd keys or
something?

Peter



More information about the Biopython-dev mailing list