[Biopython-dev] [Bug 2657] Improved Bio/Statistics/lowess.py

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2657





------- Comment #10 from mdehoon at ims.u-tokyo.ac.jp  2008-11-14 23:04 EST -------
A few comments:

1) Is there a reason to use numpy.abs instead of Python's built-int abs? Timing
these two functions suggests that they are equally fast.
2) I have no objection against James' suggestion to speed up the code. The
original call to numpy.linalg.solve was probably overkill.
3) Can you submit a unit test that does not use scipy and rpy? We should avoid
adding additional dependencies to Biopython.
4) In the long run, I am not sure whether Biopython is the right place for the
lowess function. Probably NumPy or Matplotlib would be better. (that shouldn't
stop us from improving the code here, though).


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.