[Biopython-dev] PATCH: NumPy support for BioPython

Michiel de Hoon mdehoon at c2b2.columbia.edu
Sun Mar 11 19:32:32 UTC 2007

Ed Schofield wrote:
> It's a minor issue, but I can see several reasons to use the header file 
> NumPy provides for the purpose, rather than pasting its definitions into 
> our own source files:

I am not suggesting to paste the definitions in oldnumeric.h into our 
own source files. The point is that we don't need any of the definitions 
in oldnumeric.h. So we don't need to #include them, and we also don't 
need to paste them into Biopython.

For example, your patch adds these lines (among others) to 

	#if (NDARRAY_VERSION >= 0x00090908)
	#include "numpy/oldnumeric.h"

AFAICT, these three lines can simply be removed.


More information about the Biopython-dev mailing list