[Biojava-l] IndexedSequenceDB

Gerald Loeffler Gerald.Loeffler@vienna.at
Wed, 23 Aug 2000 12:04:33 +0200


hi!

I've a few comments regarding class IndexedSequenceDB. Since the author
of this class is not given in the source code, i can't direct these
comments directly to him/her:

o method openDB() behaves differently than it is documented in its
JavaDoc comment: when the given index file does not exist, it throws an
exception.
o methods such as addFile() and especially commit() should really be
synchronized!
o i may be completely blind here but why are the non-final fields
fileToReaders and idToSource initialised in a static initialiser block?

    cheers,
    gerald