[Biojava-dev] review/feedback: code style

[Michael Heuer]

Hello Hannes,

I'm not an IDE user but what you have there looks pretty reasonable.
If given a choice I would prefer

spaces not tabs
4 spaces per indent for java files
2 spaces per indent for xml files e.g. pom.xml
120 character line length
use final by default
make classes immutable by default

I don't think adding those Eclipse formatting files and using them
going forward will be controversial; wanting to reformat all the
existing source code might be.

   michael


On Fri, Apr 5, 2013 at 4:57 PM, Spencer Bliven <sbliven at ucsd.edu> wrote:
> Hannes-
>
> If you submit a pull request now then we can comment directly on the code
> on github. Then all the discussion will be in one place, plus any future
> code you submit on that branch will get pulled into the discussion. Pull
> requests don't need to be resolved right away for potentially controversial
> changes like this.
>
>
> On Fri, Apr 5, 2013 at 12:01 PM, Hannes Brandstätter-Müller <
> biojava at hannes.oib.com> wrote:
>
>> I put together some instructions and configurations that I think could
>> greatly benefit the project code style.
>>
>> Please check them out at
>>
>> https://github.com/brandstaetter/biojava/commit/0b11b10a051cbcc1d667ed253da7fa9be11e9d59
>> and give me feedback please (ideally, download the configurations and try
>> them out)
>>
>> If there are no objections, I will submit a pull request or directly merge
>> it.
>>
>> Hannes
>>
>> p.s. what in my git config is misconfigured so that the name is not matched
>> to my github account? do I need to use my github account name in my config?
>> _______________________________________________
>> biojava-dev mailing list
>> biojava-dev at lists.open-bio.org
>> http://lists.open-bio.org/mailman/listinfo/biojava-dev
>>
>
> _______________________________________________
> biojava-dev mailing list
> biojava-dev at lists.open-bio.org
> http://lists.open-bio.org/mailman/listinfo/biojava-dev