<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Ah … just having version Biopython 1.68 would have solved my problem. I have 1.67. Dang.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks a lot,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> Bastien<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Calibri",sans-serif;color:#008FD5">--
<br>
DSM Nutritional Products Microbia Inc | Bioinformatics<br>
60 Westview Street | Lexington, MA 02421 | United States<br>
Phone +1 781 259 7613 | Fax +1 781 259 0615</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Kevin Bonham [mailto:kevbonham@gmail.com]
<br>
<b>Sent:</b> Thursday, February 02, 2017 2:57 PM<br>
<b>To:</b> Peter Cock <p.j.a.cock@googlemail.com>; Chevreux, Bastien <bastien.chevreux@dsm.com><br>
<b>Cc:</b> biopython@biopython.org<br>
<b>Subject:</b> Re: [Biopython] LOCUS name length on GenBank output: option to adjust?<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">--- This mail has been sent from an external source ---
<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">I just wanted to note that there was a similar discussion in
<a href="https://github.com/biopython/biopython/issues/747">#747</a> which I submitted about a year ago. I'm not sure if it adds anything to the discussion, but since the issue and Bastien's proposed change is similar to what I suggested I thought I'd throw
it out there. <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I think the behavior implemented in <a href="https://github.com/biopython/biopython/pull/802">
#802</a> is a good solution, and agree additional complexity is not advisable. In the situation I linked to above, I ended up storing the longer names in a dictionary and used short keys for everything that biopython dealt with. Then when I was all done, I
went back and re-wrote the locus lines using the dictionary and normal file I/O. It's a messy hack but I can go dig up the code if it would be helpful.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Cheers!<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Kevin<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Thu, Feb 2, 2017 at 2:11 PM Peter Cock <<a href="mailto:p.j.a.cock@googlemail.com">p.j.a.cock@googlemail.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">I was alluding to this paragraph in <a href="ftp://ftp.ncbi.nih.gov/genbank/gbrel.txt" target="_blank">
ftp://ftp.ncbi.nih.gov/genbank/gbrel.txt</a><br>
<br>
Although each of these data values can be found at column-specific<br>
positions, we encourage those who parse the contents of the LOCUS<br>
line to use a token-based approach. This will prevent the need for<br>
software changes if the spacing of the data values ever has to be<br>
modified.<br>
<br>
See also <a href="https://github.com/biopython/biopython/issues/526#issuecomment-276994748" target="_blank">
https://github.com/biopython/biopython/issues/526#issuecomment-276994748</a><br>
<br>
Given the current Bio.SeqIO API, I take it you are suggesting a<br>
file format variant like "genbank-relaxed" or "genbank-strict"?<br>
(Precedent with the FASTQ variants, or PHYLIP in AlignIO)<br>
<br>
I would prefer just to have one GenBank mode - it is complicated<br>
enough already.<br>
<br>
Peter<br>
<br>
On Thu, Feb 2, 2017 at 5:33 PM, Chevreux, Bastien<br>
<<a href="mailto:bastien.chevreux@dsm.com" target="_blank">bastien.chevreux@dsm.com</a>> wrote:<br>
> I could not find any discussion about LOCUS line and separators, so I cannot comment on that.<br>
><br>
> The way I would implement output in BioPython is a mode flag. If set to strict (default) it would give exactly what we have today, if set to 'loose' it would try to wiggle name and size numbers into the available space for name and size, leaving the rest
untouched. That would leave the possibility to have a "separator" mode sometime later should LOCUS lines switch to that.<br>
><br>
> B.<br>
><br>
> --<br>
> DSM Nutritional Products Microbia Inc | Bioinformatics<br>
> 60 Westview Street | Lexington, MA 02421 | United States<br>
> Phone <a href="tel:(781)%20259-7613" target="_blank">+1 781 259 7613</a> | Fax <a href="tel:(781)%20259-0615" target="_blank">
+1 781 259 0615</a><br>
><br>
> -----Original Message-----<br>
> From: Peter Cock [mailto:<a href="mailto:p.j.a.cock@googlemail.com" target="_blank">p.j.a.cock@googlemail.com</a>]<br>
> Sent: Thursday, February 02, 2017 10:39 AM<br>
> To: Chevreux, Bastien <<a href="mailto:bastien.chevreux@dsm.com" target="_blank">bastien.chevreux@dsm.com</a>><br>
> Cc: <a href="mailto:biopython@biopython.org" target="_blank">biopython@biopython.org</a><br>
> Subject: Re: [Biopython] LOCUS name length on GenBank output: option to adjust?<br>
><br>
> --- This mail has been sent from an external source ---<br>
><br>
><br>
> I've not checked lately but has there been any progress on the NCBI moving GenBank format away from a strict positional interpretation of the LOCUS line to being separator based? The issue and discussion you referenced was back in 2015...<br>
><br>
> Practically speaking perhaps we could write a spec-breaking minimal LOCUS line (leaving out things like the date and division which make parsing a problem once the column positions are lost) with a warning?<br>
><br>
> Peter<br>
><br>
><br>
> On Thu, Feb 2, 2017 at 3:16 PM, Chevreux, Bastien <<a href="mailto:bastien.chevreux@dsm.com" target="_blank">bastien.chevreux@dsm.com</a>> wrote:<br>
>> Dear list,<br>
>><br>
>><br>
>><br>
>> could BioPython implement an option to adjust the strictness of name<br>
>> length checking of a sequence when writing GenBank output?<br>
>><br>
>><br>
>><br>
>> I am aware of the short discussion in<br>
>><br>
>> <a href="https://github.com/biopython/biopython/issues/526" target="_blank">https://github.com/biopython/biopython/issues/526</a><br>
>><br>
>><br>
>><br>
>> and that BioPython wants to be strict on writing GenBank. However, I<br>
>> beg to reconsider this decision and allow for a user override.<br>
>><br>
>><br>
>><br>
>> Background: annotation of metagenomics / metatranscriptomic datasets<br>
>> where one can easily have a million contigs or more. Projects were<br>
>> named accordingly short so that names of DNA sequences fit into 16 characters.<br>
>> However, what was not considered was GenBank output of peptides, where<br>
>> the locus names are<br>
>> <name_of_contig>+<underscore>+<CDScounter_in_contig> … and that may go up to 20.<br>
>><br>
>><br>
>><br>
>> As we are talking protein sequences here and there is no known protein<br>
>>>99999 amino acids, there would be a lot of wiggle room to allow the<br>
>>>user to<br>
>> set a 20 char limit (or more) during GB output.<br>
>><br>
>><br>
>><br>
>> Best,<br>
>><br>
>> Bastien<br>
>><br>
>><br>
>><br>
>> --<br>
>> DSM Nutritional Products Microbia Inc | Bioinformatics<br>
>> 60 Westview Street | Lexington, MA 02421 | United States Phone +1 781<br>
>> 259 7613 | Fax <a href="tel:(781)%20259-0615" target="_blank">+1 781 259 0615</a><br>
>><br>
>><br>
>><br>
>><br>
>> ________________________________<br>
>><br>
>> DISCLAIMER:<br>
>> This e-mail is for the intended recipient only.<br>
>> If you have received it by mistake please let us know by reply and<br>
>> then delete it from your system; access, disclosure, copying,<br>
>> distribution or reliance on any of it by anyone else is prohibited.<br>
>> If you as intended recipient have received this e-mail incorrectly,<br>
>> please notify the sender (via e-mail) immediately.<br>
>><br>
>> _______________________________________________<br>
>> Biopython mailing list - <a href="mailto:Biopython@mailman.open-bio.org" target="_blank">
Biopython@mailman.open-bio.org</a><br>
>> <a href="http://mailman.open-bio.org/mailman/listinfo/biopython" target="_blank">
http://mailman.open-bio.org/mailman/listinfo/biopython</a><br>
<br>
_______________________________________________<br>
Biopython mailing list - <a href="mailto:Biopython@mailman.open-bio.org" target="_blank">
Biopython@mailman.open-bio.org</a><br>
<a href="http://mailman.open-bio.org/mailman/listinfo/biopython" target="_blank">http://mailman.open-bio.org/mailman/listinfo/biopython</a><o:p></o:p></p>
</blockquote>
</div>
<div>
<p class="MsoNormal">-- <o:p></o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal">Lecturer, Harvard Medical School<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">617-432-2210<o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</body>
</html>