<p dir="ltr">Yeah, sure, sounds good.</p>
<p dir="ltr">As for preference, I'd put it under .git, users shouldn't have to worry about it. </p>
<br><div class="gmail_quote"><div dir="ltr">On qui, 21/09/2017, 08:25 Peter Cock <<a href="mailto:p.j.a.cock@googlemail.com">p.j.a.cock@googlemail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Great.<br>
<br>
What would you like to have automatically assigned to you<br>
to review? Changes touching Bio/PDB/* perhaps?<br>
<br>
Also any preference putting the magic file CODEOWNERS<br>
at top level, or under .github/CODEOWNERS instead?<br>
<br>
Peter<br>
<br>
P.S. Returning to the other thread, the master branch is<br>
now protected and should only be changed via tested<br>
pull requests:<br>
<br>
<a href="http://mailman.open-bio.org/pipermail/biopython-dev/2017-September/021872.html" rel="noreferrer" target="_blank">http://mailman.open-bio.org/pipermail/biopython-dev/2017-September/021872.html</a><br>
<br>
<br>
On Thu, Sep 21, 2017 at 4:21 PM, João Rodrigues<br>
<<a href="mailto:j.p.g.l.m.rodrigues@gmail.com" target="_blank">j.p.g.l.m.rodrigues@gmail.com</a>> wrote:<br>
> Hi Peter,<br>
><br>
> Sounds like a good policy to me. Also for the branch protection, makes<br>
> perfect sense.<br>
><br>
> Cheers,<br>
><br>
> João<br>
><br>
><br>
> On qua, 20/09/2017, 14:13 Peter Cock <<a href="mailto:p.j.a.cock@googlemail.com" target="_blank">p.j.a.cock@googlemail.com</a>> wrote:<br>
>><br>
>> Hi all,<br>
>><br>
>> I recently learnt of another GitHub feature which may be<br>
>> of use for Biopython:<br>
>><br>
>> <a href="https://github.com/blog/2392-introducing-code-owners" rel="noreferrer" target="_blank">https://github.com/blog/2392-introducing-code-owners</a><br>
>><br>
>> The Galaxy Project are now trying this for their repository of<br>
>> training materials (which is how I heard about the idea):<br>
>><br>
>> <a href="https://github.com/galaxyproject/training-material/pull/539" rel="noreferrer" target="_blank">https://github.com/galaxyproject/training-material/pull/539</a><br>
>><br>
>> The idea is we can label a default owner for files or entire<br>
>> folders, and if a pull request changes those files, GitHub<br>
>> will automatically assign their owner as a reviewer.<br>
>><br>
>> For example, we might include the following mappings:<br>
>><br>
>> Bio/Cluster/* @mdehoon<br>
>> Bio/SeqIO/* @peterjc<br>
>> Bio/PopGen/* @tiagoantao<br>
>> Bio/Phylo/* @etal<br>
>> ...<br>
>><br>
>> This can be combined with the branch protection options,<br>
>> which I proposed using recently:<br>
>><br>
>><br>
>> <a href="http://mailman.open-bio.org/pipermail/biopython-dev/2017-August/021861.html" rel="noreferrer" target="_blank">http://mailman.open-bio.org/pipermail/biopython-dev/2017-August/021861.html</a><br>
>><br>
>> Peter<br>
>> _______________________________________________<br>
>> Biopython-dev mailing list<br>
>> <a href="mailto:Biopython-dev@mailman.open-bio.org" target="_blank">Biopython-dev@mailman.open-bio.org</a><br>
>> <a href="http://mailman.open-bio.org/mailman/listinfo/biopython-dev" rel="noreferrer" target="_blank">http://mailman.open-bio.org/mailman/listinfo/biopython-dev</a><br>
</blockquote></div>