<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Thanks for all the pointers, looks like you made the changes and applied them. I will make changes to the "<span style="font-family:arial,sans-serif;font-size:13px">Searching for and downloading abstracts using the history" section and submit another pull request.</span></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div>Vincent Davis</div><div>720-301-3003<span></span><span></span></div></div></div>
<br><div class="gmail_quote">On Mon, Dec 1, 2014 at 3:06 AM, Peter Cock <span dir="ltr"><<a href="mailto:p.j.a.cock@googlemail.com" target="_blank">p.j.a.cock@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Dec 1, 2014 at 2:04 AM, Vincent Davis <<a href="mailto:vincent@vincentdavis.net">vincent@vincentdavis.net</a>> wrote:<br>
> I submitted a pull request, let me know if this is what you had in mind.<br>
><br>
> Vincent Davis<br>
<br>
</span>Thanks Vincent,<br>
<br>
Yes, that's what I was hoping for :)<br>
<br>
I made some comments on <a href="https://github.com/biopython/biopython/pull/436" target="_blank">https://github.com/biopython/biopython/pull/436</a><br>
<br>
Can you look at those and update the pull request? The simplest way is<br>
make a second commit on your branch, and push the updated branch to<br>
github which will automatically update the pull request.<br>
<br>
As an aside, since you are working on that example, we ought to make it<br>
more PEP8 compliant - note the white space changes from:<br>
<br>
for start in range(0,count,batch_size):<br>
end = min(count, start+batch_size)<br>
print("Going to download record %i to %i" % (start+1, end))<br>
<br>
to:<br>
<br>
for start in range(0, count, batch_size):<br>
end = min(count, start + batch_size)<br>
print("Going to download record %i to %i" % (start + 1, end))<br>
<br>
There are probably quite a few bits like that still in the Tutorial, but this<br>
is not urgent.<br>
<br>
Thanks,<br>
<br>
Peter<br>
</blockquote></div><br></div>