<div dir="ltr">Forgot reply to all.<br><div><div class="gmail_quote"><div dir="ltr"><div>Just ran pep8 on the latest commit and got almost 30,000 errors. Looks like we have our work cut out for us. Should we discuss formatting choices for docstrings before starting on the PEP8 corrections so that both can be updated at the same time as we go through the code? Or should the tasks be separate?<span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888">-Travis<br></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 20, 2014 at 8:02 AM, Christian Brueffer <span dir="ltr"><<a href="mailto:christian@brueffer.de" target="_blank">christian@brueffer.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Peter,<br>
<br>
indeed, there is more than one way to install pep8. Windows feedback would be great, I don't have a test machine for that.<br>
<br>
One nice feature of pep8 is getting overall statistics with pep8 --statistics -qq from the top level repository directory. Maybe it would be interesting to set up a job to automatically send these statistics to this list in certain intervals (i.e., once a month).<br>
<br>
Chris<div><div><br>
<br>
<br>
On 2014-10-20 13:31, Peter Cock wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks Christian,<br>
<br>
I'm giving that a try on my mac - note you don't need pip to install pep8,<br>
<br>
$ curl -O <a href="https://pypi.python.org/packages/source/p/pep8/pep8-1.5.7.tar.gz" target="_blank">https://pypi.python.org/<u></u>packages/source/p/pep8/pep8-1.<u></u>5.7.tar.gz</a><br>
$ tar -zxvf pep8-1.5.7.tar.gz<br>
$ md5 pep8-1.5.7.tar.gz<br>
MD5 (pep8-1.5.7.tar.gz) = f6adbdd69365ecca20513c709f9b7c<u></u>93<br>
$ cd pep8-1.5.7<br>
$ sudo python setup.py install<br>
$ which pep8<br>
/usr/local/bin/pep8<br>
$ head -n 1 /usr/local/bin/pep8<br>
#!/usr/bin/python<br>
$ pep8 --version<br>
1.5.7<br>
<br>
Note we want pep8 installed as a binary on the path (which is itself<br>
a Python script). This is then called by git via the pre-commit hook -<br>
the hook from Christian is another Python script (using the default<br>
system python) which calls the pep8 binary.<br>
<br>
I would hope this is doable on Windows too...<br>
<br>
Peter<br>
<br>
On Mon, Oct 20, 2014 at 11:32 AM, Christian Brueffer<br>
<<a href="mailto:christian@brueffer.de" target="_blank">christian@brueffer.de</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi everyone,<br>
<br>
TL;DR: lots of style problems in biopython code, please consider using the<br>
git pre-commit hook at <a href="https://github.com/cbrueffer/pep8-git-hook" target="_blank">https://github.com/cbrueffer/<u></u>pep8-git-hook</a> (or check<br>
your files manually with the pep8 utility).<br>
<br>
<br>
Long version:<br>
<br>
Since the last round of PEP8 fixes to the biopython repo almost two years<br>
ago, many classes of inconsistencies have unfortunately slowly crept back<br>
in.<br>
<br>
One way to check the code you're committing is via a git pre-commit hook,<br>
which tells you which kinds of problems your submissions contain.<br>
<br>
Such a commit hook can be found here:<br>
<br>
<a href="https://github.com/cbrueffer/pep8-git-hook" target="_blank">https://github.com/cbrueffer/<u></u>pep8-git-hook</a><br>
<br>
Installation is easy, simply copy the pre-commit file from the above<br>
repository into the following directory in your biopython checkout:<br>
.git/hooks<br>
You also need the pep8 utility (pip install pep8).<br>
<br>
A list of problem classes pep8 reports can be found here:<br>
<a href="http://pep8.readthedocs.org/en/latest/intro.html#error-codes" target="_blank">http://pep8.readthedocs.org/<u></u>en/latest/intro.html#error-<u></u>codes</a><br>
<br>
By default the hook checks for all of these problems, except the following<br>
ones: E121-E129, E131, and E501 (indentation and long lines).<br>
<br>
The way it works is, the hook stops your commit and tells you which issues<br>
your code contains. The hook won't bother you if the files in the commit<br>
contain no issues, or you commit with --no-verify (e.g., git commit -a<br>
--no-verify). The latter is especially for situations where your code is<br>
fine, but files contain pre-existing issues.<br>
<br>
Please test this and let me know what you think, whether the list of issues<br>
should be adapted etc. Continuous checking would improve our code<br>
consistency a lot in the long run.<br>
<br>
Cheers,<br>
<br>
Chris<br>
______________________________<u></u>_________________<br>
Biopython-dev mailing list<br>
<a href="mailto:Biopython-dev@mailman.open-bio.org" target="_blank">Biopython-dev@mailman.open-<u></u>bio.org</a><br>
<a href="http://mailman.open-bio.org/mailman/listinfo/biopython-dev" target="_blank">http://mailman.open-bio.org/<u></u>mailman/listinfo/biopython-dev</a><br>
</blockquote></blockquote>
______________________________<u></u>_________________<br>
Biopython-dev mailing list<br>
<a href="mailto:Biopython-dev@mailman.open-bio.org" target="_blank">Biopython-dev@mailman.open-<u></u>bio.org</a><br>
<a href="http://mailman.open-bio.org/mailman/listinfo/biopython-dev" target="_blank">http://mailman.open-bio.org/<u></u>mailman/listinfo/biopython-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div></div><br></div></div>