<div dir="ltr"><div><div><div><div>Ben,<br><br></div>This sounds like a great idea and a really useful addition to biojava! I would lean towards only parsing the consensus tree, as the other formats are pretty specific use cases. We're sure forester doesn't provide Nexus parsing, right? The documentation isn't particularly complete, but it's already a phylo dependency so we should avoid duplicating any features.<br><br></div>As to your second suggestion, it sounds very similar to how FastaReader currently works, with the user providing a SequenceCreator which instantiates whatever Sequence implementation you want to use. Mutable sequences can lead to a host of additional problems, which is why the sequences are currently generated atomically. Or am I misunderstanding your suggestion?<br><br></div>It would be fantastic to have some additional development of multiple alignments and the phylo package! Thanks for the offer to contribute!<br><br></div>-Spencer<br> </div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 6, 2014 at 12:19 PM, Jose Manuel Duarte <span dir="ltr"><<a href="mailto:jose.duarte@psi.ch" target="_blank">jose.duarte@psi.ch</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Ben<br>
<br>
Thanks a lot for all the insights. I am really not the most appropriate person to comment on all the biojava phylogeny and sequence related things but anyway below are some of my opinions.<span class=""><br>
<br>
<br>
On 05/11/14 17:22, Ben Stöver wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
The more interesting/urgent thing though might be parsing the consensus tree<br>
which is in Nexus format (or writing the input files for MrBayes). Although<br>
the Nexus format is not really state of the art anymore and replacements like<br>
e.g. NeXML (<a href="http://nexml.org/" target="_blank">http://nexml.org/</a> ) - which overcome its limitations - should be<br>
prefered if you implement a new software, the Nexus format is still widely<br>
used and supporting in BioJava 3 (or 4) would surely be a good idea. There was<br>
a extensible Nexus parser in BioJava 1.x<br>
(<a href="http://www.biojava.org/docs/api1.9.1/org/biojavax/bio/phylo/io/nexus/package-summary.html" target="_blank">http://www.biojava.org/docs/<u></u>api1.9.1/org/biojavax/bio/<u></u>phylo/io/nexus/package-<u></u>summary.html</a><br>
) which could be ported to BioJava 3 (4). (This has never been done until now,<br>
hasen't it?)<br>
</blockquote>
<br></span>
If I understand it properly they were not ported yet to 3 because of lack of time, so I think the porting of the nexus stuff would be a great thing. +1 to that.<span class=""><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Therefore I would offer to implement such functionality for BioJava, but<br>
before making a pull request or anything, I wanted to ask for opinion of the<br>
cummunity on that idea and also if I might have missed concepts in BioJava<br>
that would currently already allow to do something similar.<br>
</blockquote>
<br></span>
To me the whole idea sounds great. Especially if it can be made compatible with the existing Biojava interfaces. If I understand what you propose, you would only introduce a new way of parsing things which could even live alongside the current parsers. It could even go to its own package (sequence.nio ?). For me this is a +1 too.<br>
<br>
Cheers<span class="HOEnZb"><font color="#888888"><br>
<br>
Jose</font></span><div class="HOEnZb"><div class="h5"><br>
______________________________<u></u>_________________<br>
Biojava-l mailing list - <a href="mailto:Biojava-l@mailman.open-bio.org" target="_blank">Biojava-l@mailman.open-bio.org</a><br>
<a href="http://mailman.open-bio.org/mailman/listinfo/biojava-l" target="_blank">http://mailman.open-bio.org/<u></u>mailman/listinfo/biojava-l</a></div></div></blockquote></div><br></div>