[Biojava-dev] [patch] (trivial) fix for use of longs as unsigned ints in SCF.java

Matthew Pocock matthew_pocock at yahoo.co.uk
Sun Aug 24 16:48:42 EDT 2003


Thanks for these two patches. Unless someone who knows
these two classes screams "STOP", I'll apply them
Monday.

Matthew 

 --- Joe Burks <joe at wavicle.org> wrote: 
> I believe the intention of lines such as:
>                  hs.samples          = 0xFFFFFFFF &
> din.readInt();
> was to allow the long value 'samples' to hold the
> integer read as 
> unsigned.  Since both arguments are integers in this
> case, type promotion 
> wasn't happening until assignment and large values
> were being sign extended 
> into the long value.  This patch should fix those.
> 
> -Joe

> ATTACHMENT part 2 application/octet-stream
name=scf.diff; x-mac-type=42494E41;
x-mac-creator=5843454C
> _______________________________________________
> biojava-dev mailing list
> biojava-dev at biojava.org
> http://biojava.org/mailman/listinfo/biojava-dev
>  

________________________________________________________________________
Want to chat instantly with your online friends?  Get the FREE Yahoo!
Messenger http://uk.messenger.yahoo.com/


More information about the biojava-dev mailing list